Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/resource/aws_ec2_client_vpn_endpoint: Add sweeper #8155

Merged
merged 2 commits into from
Apr 5, 2019
Merged

tests/resource/aws_ec2_client_vpn_endpoint: Add sweeper #8155

merged 2 commits into from
Apr 5, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 2, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Previous output from acceptance testing:

--- FAIL: TestAccAwsEc2ClientVpnEndpoint_basic (5.71s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_ec2_client_vpn_endpoint.test: 1 error occurred:
        	* aws_ec2_client_vpn_endpoint.test: Error creating Client VPN endpoint: ClientVpnEndpointLimitExceeded: Limit exceeded

Previously output from AWS CLI:

$ aws ec2 describe-client-vpn-endpoints | jq '.ClientVpnEndpoints | length'
5

Output from sweeper:

$ go test ./aws -v -sweep=us-west-2 -sweep-run=aws_ec2_client_vpn_endpoint -timeout 10h
...
2019/04/02 12:46:28 [INFO] Deleting Client VPN Endpoint: cvpn-endpoint-073bf6cb2791e2d37
2019/04/02 12:46:28 [INFO] Deleting Client VPN Endpoint: cvpn-endpoint-056499587fe3f59c6
2019/04/02 12:46:29 [INFO] Deleting Client VPN Endpoint: cvpn-endpoint-0e92f7d99d531d5ae
2019/04/02 12:46:31 [INFO] Deleting Client VPN Endpoint: cvpn-endpoint-0b4741c9520d69d36
2019/04/02 12:46:31 [INFO] Deleting Client VPN Endpoint: cvpn-endpoint-0c5fadd250f9ca007
2019/04/02 12:46:32 Sweeper Tests ran:
	- aws_ec2_client_vpn_endpoint
	- aws_directory_service_directory
ok  	github.com/terraform-providers/terraform-provider-aws/aws	9.578s

Output from AWS CLI:

$ aws ec2 describe-client-vpn-endpoints | jq '.ClientVpnEndpoints | length'
0

@bflad
tests/resource/aws_ec2_client_vpn_endpoint: Add sweeper
1e71e3f 
Previous output from acceptance testing:

```
--- FAIL: TestAccAwsEc2ClientVpnEndpoint_basic (5.71s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_ec2_client_vpn_endpoint.test: 1 error occurred:
        	* aws_ec2_client_vpn_endpoint.test: Error creating Client VPN endpoint: ClientVpnEndpointLimitExceeded: Limit exceeded
```

Previously output from AWS CLI:

```console
$ aws ec2 describe-client-vpn-endpoints | jq '.ClientVpnEndpoints | length'
5
```

Output from sweeper:

```console
$ go test ./aws -v -sweep=us-west-2 -sweep-run=aws_ec2_client_vpn_endpoint -timeout 10h
...
2019/04/02 12:46:28 [INFO] Deleting Client VPN Endpoint: cvpn-endpoint-073bf6cb2791e2d37
2019/04/02 12:46:28 [INFO] Deleting Client VPN Endpoint: cvpn-endpoint-056499587fe3f59c6
2019/04/02 12:46:29 [INFO] Deleting Client VPN Endpoint: cvpn-endpoint-0e92f7d99d531d5ae
2019/04/02 12:46:31 [INFO] Deleting Client VPN Endpoint: cvpn-endpoint-0b4741c9520d69d36
2019/04/02 12:46:31 [INFO] Deleting Client VPN Endpoint: cvpn-endpoint-0c5fadd250f9ca007
2019/04/02 12:46:32 Sweeper Tests ran:
	- aws_ec2_client_vpn_endpoint
	- aws_directory_service_directory
ok  	github.com/terraform-providers/terraform-provider-aws/aws	9.578s
```

Output from AWS CLI:

```console
$ aws ec2 describe-client-vpn-endpoints | jq '.ClientVpnEndpoints | length'
0
```
@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. labels Apr 2, 2019
@bflad bflad requested a review from a team April 2, 2019 16:51
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Apr 2, 2019
nywilken
nywilken reviewed Apr 5, 2019
View reviewed changes
aws/resource_aws_ec2_client_vpn_endpoint_test.go Outdated
@@ -94,7 +155,7 @@ func TestAccAwsEc2ClientVpnEndpoint_withLogGroup(t *testing.T) {
})
}

func TestAccAwsEc2ClientVpnEndpoint_withDNSServers(t *testing.T) {
func TestAccAwsEc2ClientVpnEndpoint_withDNervers(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this rename intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 Great catch

nywilken
nywilken approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one question on what looks to be an accidental rename, otherwise this looks good!

@bflad bflad added this to the v2.5.0 milestone Apr 5, 2019
@bflad bflad merged commit 0d148e5 into master Apr 5, 2019
@bflad bflad deleted the t-aws_ec2_client_vpn_endpoint-sweeper branch April 5, 2019 04:14
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @nywilken